Differential D1994

Fix parsing of geo coordinates in locale encoding (+ extend unit test)
ClosedPublic
Actions

Authored by kossebau on Jun 24 2016, 3:41 PM.

Details

Reviewers
nienhueser
rahn
Group Reviewers
Marble
Commits
R34:1b1de18783ca: Fix parsing of geo coordinates in locale encoding (+ extend unit test)
R34:4686af98915e: Fix parsing of geo coordinates in locale encoding (+ extend unit test)
Summary

QString::toDouble in Qt5 no longer first tries the system locale

In tests also prefer QLocale::toString over "%L1", in some Qt versionns
(e.g. 5.6) the L might only work when QLocale::setDefault has been
explicitely called.

Test Plan

Unit tests haven been improved and are all passing.
marble --latlon "46,09898 7,78307" in German locale works now as expected

Diff Detail

Repository
R34 Marble
Branch
fixLocaledGeoCoordParsing
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau updated this revision to Diff 4705.Jun 24 2016, 3:41 PM
kossebau retitled this revision from to Fix parsing of geo coordinates in locale encoding (+ extend unit test).
kossebau updated this object.
kossebau edited the test plan for this revision. (Show Details)
kossebau added reviewers: Marble, nienhueser, rahn.
nienhueser accepted this revision.Jun 24 2016, 3:51 PM
nienhueser edited edge metadata.

Please push.

This revision is now accepted and ready to land.Jun 24 2016, 3:51 PM
Closed by commit R34:4686af98915e: Fix parsing of geo coordinates in locale encoding (+ extend unit test) (authored by kossebau). · Explain WhyJun 24 2016, 4:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4705

View Options

src/lib/marble/geodata/data/GeoDataCoordinates.cpp

Loading...
View Options

tests/TestGeoDataCoordinates.cpp

Loading...