kcmshell5 depends on plasma-workspace. By using our own tiny wrapper for opening the KCM we avoid pulling
in plasma-workspace and everything that comes with it on non-Plasma systems.
Details
Details
- Reviewers
sredman - Group Reviewers
KDE Connect - Commits
- R224:d26d2ada78bd: Don't use kcmshell5 for opening the KCM
kdeconnect-settings shows the KCM
Diff Detail
Diff Detail
- Repository
- R224 KDE Connect
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
It works for me. I like this a lot better than before because I could never remember how to launch the settings panel! If you like, I can test it on my Ubuntu 18.04 Gnome VM before you merge.
Comment Actions
I think this is fine as a temporary solution but we should look into fixing kcmshell dependencies. It uses KWorkspace lib from plasma-workspace for determining the Qt platform to use. And that ends up pulling in everything and the kitchen sink :/