Differential D17383

Don't use kcmshell5 for opening the KCM
ClosedPublic
Actions

Authored by nicolasfella on Dec 6 2018, 3:04 PM.

Details

Reviewers
sredman
Group Reviewers
KDE Connect
Commits
R224:d26d2ada78bd: Don't use kcmshell5 for opening the KCM
Summary

kcmshell5 depends on plasma-workspace. By using our own tiny wrapper for opening the KCM we avoid pulling
in plasma-workspace and everything that comes with it on non-Plasma systems.

Test Plan

kdeconnect-settings shows the KCM

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Dec 6 2018, 3:04 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 6 2018, 3:04 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Dec 6 2018, 3:04 PM
nicolasfella updated this revision to Diff 46965.Dec 6 2018, 3:05 PM
  • Add missing file
nicolasfella updated this revision to Diff 46966.Dec 6 2018, 3:06 PM
  • Correct license header
sredman accepted this revision.Dec 6 2018, 8:39 PM
sredman added a subscriber: sredman.

It works for me. I like this a lot better than before because I could never remember how to launch the settings panel! If you like, I can test it on my Ubuntu 18.04 Gnome VM before you merge.

This revision is now accepted and ready to land.Dec 6 2018, 8:39 PM
Closed by commit R224:d26d2ada78bd: Don't use kcmshell5 for opening the KCM (authored by nicolasfella). · Explain WhyDec 6 2018, 10:10 PM
This revision was automatically updated to reflect the committed changes.
broulik added a subscriber: broulik.Dec 7 2018, 11:48 AM

I think this is fine as a temporary solution but we should look into fixing kcmshell dependencies. It uses KWorkspace lib from plasma-workspace for determining the Qt platform to use. And that ends up pulling in everything and the kitchen sink :/

Revision Contents
Changeset List

PathPackages
Mkcm/CMakeLists.txt (5 lines)
AMkcm/main.cpp (48 lines)
Mkcm/org.kde.kdeconnect.kcm.desktop (2 lines)

Diff 47002

View Options

kcm/CMakeLists.txt

Loading...
View Options

kcm/main.cpp

Loading...
View Options

kcm/org.kde.kdeconnect.kcm.desktop

Loading...