Differential D16954

Add find module for Google's libphonenumber
ClosedPublic
Actions

Authored by vkrause on Nov 17 2018, 11:10 AM.

Details

Reviewers
krop
Group Reviewers
Build System
Frameworks
Commits
R240:ebb05ecafb02: Add find module for Google's libphonenumber
Summary

This is currently in use by plasma-phone-components, but will also be
needed by KItinerary.

Diff Detail

Repository
R240 Extra CMake Modules
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5679
Build 5697: arc lint + arc unit
vkrause created this revision.Nov 17 2018, 11:10 AM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptNov 17 2018, 11:10 AM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Nov 17 2018, 11:10 AM
krop added a subscriber: krop.Dec 1 2018, 9:11 PM
krop added inline comments.
find-modules/FindPhoneNumber.cmake
28

Since 5.53

86

phonenumber doesn't install a pkg-config file, this variable is empty

krop added inline comments.Dec 1 2018, 9:16 PM
find-modules/FindPhoneNumber.cmake
86

Note: this is harmless, but maybe just add

set(PhoneNumber_VERSION 0)

to make it clear. AFAICS, none of the public headers contain the library version

vkrause updated this revision to Diff 46805.Dec 3 2018, 5:53 PM

Address review comments.

krop accepted this revision.Dec 3 2018, 6:02 PM
This revision is now accepted and ready to land.Dec 3 2018, 6:02 PM
Closed by commit R240:ebb05ecafb02: Add find module for Google's libphonenumber (authored by vkrause). · Explain WhyDec 4 2018, 4:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMfind-modules/FindPhoneNumber.cmake (95 lines)

Diff 46805

View Options

find-modules/FindPhoneNumber.cmake

Loading...