Differential D16819

Use 'Copy File Path' instead of 'Copy Filename' consistently
ClosedPublic
Actions

Authored by gregormi on Nov 11 2018, 3:08 PM.

Details

Reviewers
cullmann
Group Reviewers
Kate
Commits
R40:6673ce681600: Use 'Copy File Path' instead of 'Copy Filename' consistently
Summary

In the context menus of the Document Tree View plugin, the Project plugin,
and the Tabbar, use the term Use 'Copy File Path' consistently.

Diff Detail

Repository
R40 Kate
Branch
arcpatch-D16819
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5085
Build 5103: arc lint + arc unit
gregormi created this revision.Nov 11 2018, 3:08 PM
Restricted Application added a project: Kate. · View Herald TranscriptNov 11 2018, 3:08 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
gregormi requested review of this revision.Nov 11 2018, 3:08 PM
ngraham added a subscriber: ngraham.Nov 11 2018, 3:51 PM

+1 on "Copy Path."

cullmann added a subscriber: cullmann.Nov 11 2018, 7:23 PM

Wouldn't "Copy file path" be the correct wording? But I am no export, I can live with Copy path, too ;=)

ngraham added a comment.Nov 11 2018, 8:03 PM

Yeah, "Copy file path" is fine too. Maybe even better.

gregormi added a comment.Nov 11 2018, 8:28 PM

"Copy file path" or "Copy File Path"?

kfunk added a subscriber: kfunk.Nov 15 2018, 12:58 PM
In D16819#358083, @gregormi wrote:

"Copy file path" or "Copy File Path"?

The latter. Action texts have title capitalization.

@ngraham https://hig.kde.org/style/writing/capitalization.html needs updating -- maybe add "Action texts" to the bullet point list?

ngraham added a comment.Nov 15 2018, 2:50 PM
In D16819#359752, @kfunk wrote:
In D16819#358083, @gregormi wrote:

"Copy file path" or "Copy File Path"?

The latter. Action texts have title capitalization.

@ngraham https://hig.kde.org/style/writing/capitalization.html needs updating -- maybe add "Action texts" to the bullet point list?

Good idea. I've taken the opportunity to rewrite a good deal of the page anyway: D16899

gregormi updated this revision to Diff 45735.Nov 18 2018, 5:02 PM
  • Use "Copy File Path" on three locations
gregormi retitled this revision from Use 'Copy Path' instead of 'Copy Filename' consistently to Use 'Copy File Path' instead of 'Copy Filename' consistently.Nov 18 2018, 5:04 PM
gregormi edited the summary of this revision. (Show Details)
cullmann accepted this revision.Nov 19 2018, 5:31 AM

Yep, thanks!

This revision is now accepted and ready to land.Nov 19 2018, 5:31 AM
gregormi edited the summary of this revision. (Show Details)Nov 19 2018, 10:05 PM
Closed by commit R40:6673ce681600: Use 'Copy File Path' instead of 'Copy Filename' consistently (authored by gregormi). · Explain WhyNov 19 2018, 10:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45735

View Options

addons/filetree/katefiletree.cpp

Loading...
View Options

addons/project/kateprojecttreeviewcontextmenu.cpp

Loading...
View Options

kate/kateviewspace.cpp

Loading...