--added a new configuration option in order for
users to alter the systray icons spacing in pixels.
The option can be specified through new Appearance
configuration page of the systray applet.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma VDG
-check different spacing values in order to confirm
behavior
-check both for one-line or multi-lines systray
layouts
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- systraySpacing
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 3371 Build 3389: arc lint + arc unit
applets/systemtray/package/contents/ui/main.qml | ||
---|---|---|
310 | Hmm. We might want to scale by DPI. While the default 0px will not be affected by DPI, if a Look And Feel sets it to 10px, it would look different for users with 1x DPI and 2x DPI. Eg: spacing: plasmoid.configuration.iconsSpacing * units.devicePixelRatio |
applets/systemtray/package/contents/ui/main.qml | ||
---|---|---|
310 | We probably need to round it too so that the icons start on integer coordinates. spacing: Math.round(plasmoid.configuration.iconsSpacing * units.devicePixelRatio) |
Comment Actions
FWIW I agree with @mart. Just give it a default value and leave it at that. More configuration doesn't necessarily mean better.