Differential D15471

Craft bits for D15469
ClosedPublic
Actions

Authored by arichardson on Sep 13 2018, 9:07 AM.

Details

Reviewers
vonreth
Commits
R138:1d935e924556: Craft bits for D15469
R138:397b0c440fcc: Add type hints for CraftCore.*

Diff Detail

Repository
R138 Craft
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2792
Build 2810: arc lint + arc unit
arichardson requested review of this revision.Sep 13 2018, 9:07 AM
arichardson created this revision.
arichardson updated this revision to Diff 41527.Sep 13 2018, 10:27 AM

Better approach

vonreth added a comment.Sep 13 2018, 10:56 AM

Better but can we add something to the name that indicates a boolean

arichardson updated this revision to Diff 41535.Sep 13 2018, 11:57 AM

Pick a name that shows that it is a boolean

vonreth accepted this revision.Sep 13 2018, 11:59 AM

looks good

This revision is now accepted and ready to land.Sep 13 2018, 11:59 AM
Closed by commit R138:1d935e924556: Craft bits for D15469 (authored by arichardson). · Explain WhySep 13 2018, 12:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41527

View Options

bin/BuildSystem/AutoToolsBuildSystem.py

Loading...
View Options

bin/options.py

Loading...