Update libunistring to 0.9.10 and fix build on macOS (and maybe also MinGW)
ClosedPublic

Authored by arichardson on Sep 13 2018, 8:44 AM.

Details

Summary

Gnulib really doesn't like the aclocal files that are installed with the
latest autoconf so we need to ensure that the ones from the source
directory are used instead.

See also https://lists.gnu.org/archive/html/bug-gnulib/2016-12/msg00140.html
for the same error we are seeing in jenkins happening on MinGW.

Diff Detail

Repository
R877 Craft Blueprints for KDE
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arichardson requested review of this revision.Sep 13 2018, 8:44 AM
arichardson created this revision.

Hm my fear is that this will make things more and more complicated... Would prepend ing the src location work? So use the existing config string and add -B

I have needed this for 3 packages now (libunistring, libtasn1 and aqbanking). Do we really need to override the project aclocal files with the ones from the craftroot? According to the mailing list message prefix/share/aclocal will be searched automatically.

Yes but currently we install autotools to dev-utils. And cmake would always be a problem.
If we really need this at least call it autotools includes, no need to have args and extraargs

Ah yes of course I didn't think about that. How about self.subinfo.options.configure.defaultAutoreconfIncludes = False? So far the only thing that was necessary is to not add the default include path.

Yes sounds good and less confusing

This revision was not accepted when it landed; it landed in state Needs Review.Sep 13 2018, 12:25 PM
This revision was automatically updated to reflect the committed changes.