Differential D15471

Craft bits for D15469
ClosedPublic
Actions

Authored by arichardson on Sep 13 2018, 9:07 AM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

R138:1d935e924556: Craft bits for D15469
R138:397b0c440fcc: Add type hints for CraftCore.*

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

arichardson requested review of this revision.Sep 13 2018, 9:07 AM

arichardson created this revision.

Harbormaster completed remote builds in B2788: Diff 41518.Sep 13 2018, 9:07 AM

arichardson added a dependent revision: D15469: Update libunistring to 0.9.10 and fix build on macOS (and maybe also MinGW).Sep 13 2018, 9:07 AM

Better approach

Harbormaster completed remote builds in B2792: Diff 41527.Sep 13 2018, 10:27 AM

Better but can we add something to the name that indicates a boolean

Pick a name that shows that it is a boolean

Harbormaster completed remote builds in B2800: Diff 41535.Sep 13 2018, 11:57 AM

looks good

This revision is now accepted and ready to land.Sep 13 2018, 11:59 AM

Closed by commit R138:1d935e924556: Craft bits for D15469 (authored by arichardson). · Explain WhySep 13 2018, 12:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			bin/BuildSystem/AutoToolsBuildSystem.py (17 lines)
M			bin/options.py (4 lines)

Diff 41537

bin/BuildSystem/AutoToolsBuildSystem.py

Loading...

bin/options.py

Loading...