KWin 5.13.x no longer builds against older KDecoration2 versions. Technically it requires 5.12.90 but I suppose that's not an officially recognised version number.
This patch adds a version requirement on 5.13.0 in the CMake file.
davidedmundson |
KWin |
KWin 5.13.x no longer builds against older KDecoration2 versions. Technically it requires 5.12.90 but I suppose that's not an officially recognised version number.
This patch adds a version requirement on 5.13.0 in the CMake file.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
FWIW, without this check (and an older KDecoration2), clang first complained about the override tag on non-virtual methods, and then failed to link the decoration autotest when I removed the overrides because supposedly the two request* methods weren't found. I understand the former error, the latter not so much (why wouldn't requestShowTooltip() be treated as an extension?)
If you mean that the commit message should be something like "require KDecoration > 5.12.90" then yes, that's what I'd write.