KWin requires KDecoration >= 5.12.90
ClosedPublic

Authored by rjvbb on Jul 24 2018, 8:29 AM.

Details

Summary

KWin 5.13.x no longer builds against older KDecoration2 versions. Technically it requires 5.12.90 but I suppose that's not an officially recognised version number.

This patch adds a version requirement on 5.13.0 in the CMake file.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rjvbb created this revision.Jul 24 2018, 8:29 AM
Restricted Application added a subscriber: kwin. · View Herald TranscriptJul 24 2018, 8:29 AM
rjvbb requested review of this revision.Jul 24 2018, 8:29 AM
rjvbb added a comment.Jul 24 2018, 8:32 AM

FWIW, without this check (and an older KDecoration2), clang first complained about the override tag on non-virtual methods, and then failed to link the decoration autotest when I removed the overrides because supposedly the two request* methods weren't found. I understand the former error, the latter not so much (why wouldn't requestShowTooltip() be treated as an extension?)

zzag added a subscriber: zzag.Jul 24 2018, 8:49 AM

Please use the imperative mood in the title/subject line.

If you mean that the commit message should be something like "require KDecoration > 5.12.90" then yes, that's what I'd write.

davidedmundson accepted this revision.Jul 24 2018, 10:36 AM
This revision is now accepted and ready to land.Jul 24 2018, 10:36 AM
zzag added a comment.Jul 24 2018, 10:37 AM

If you mean that the commit message should be something like "require KDecoration > 5.12.90" then yes, that's what I'd write.

Please capitalize it too, e.g. "Require KDecoration >= 5.13.0".

This revision was automatically updated to reflect the committed changes.