Differential D13856

Fix crash on post-initial refresh()
ClosedPublic
Actions

Authored by hein on Jul 2 2018, 6:40 PM.

Details

Reviewers
davidedmundson
mart
Commits
R119:e1252c6e40ac: Fix crash on post-initial refresh()
R120:dd4a69d2a660: Fix crash on post-initial refresh()
Summary

The InvalidAppsFilterProxy and GroupSortProxy models were creating
circular parent-child relationships by setting themselves as parents
of their parent objects.

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 579
Build 591: arc lint + arc unit
hein created this revision.Jul 2 2018, 6:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 2 2018, 6:40 PM
hein requested review of this revision.Jul 2 2018, 6:40 PM
davidedmundson requested changes to this revision.Jul 2 2018, 9:16 PM

The parental changes totally make sense. +1 to that.

As for the reload. We shouldn't be working round KDE code. If there's a bug it should be fixed at the right place or not at all.

This revision now requires changes to proceed.Jul 2 2018, 9:16 PM
hein added a comment.Jul 2 2018, 9:22 PM

FWIW: I'm not going to make changes to this revision until the KActivitiesStats bug is fixed, which as mentioned I don't have time to fix. So this revision is stuck for now (unless I go for maintainer authority, which the situation must show).

hein updated this revision to Diff 37105.Jul 3 2018, 2:21 PM
hein retitled this revision from Work around KActivitiesStats' ResultsModel emitting wrong moves to Fix crash on post-initial refresh().
hein edited the summary of this revision. (Show Details)

Drop the hack.

davidedmundson accepted this revision.Jul 3 2018, 2:22 PM
This revision is now accepted and ready to land.Jul 3 2018, 2:22 PM
Closed by commit R119:e1252c6e40ac: Fix crash on post-initial refresh() (authored by hein). · Explain WhyJul 3 2018, 2:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37105

View Options

applets/kicker/plugin/recentusagemodel.h

Loading...
View Options

applets/kicker/plugin/recentusagemodel.cpp

Loading...