- Go to System Settins -> Desktop Behavior > Virtual Desktops
- Open Switching tab
- Select Fade desktop
- Click the info button
Details
Details
- Reviewers
mart davidedmundson - Group Reviewers
KWin
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- fix-plugininfo-kservice-deprecation-warning
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 555 Build 567: arc lint + arc unit
Comment Actions
FWIW, with this change, KWin compiles without any warnings \o/. (well, at least with GCC)
Comment Actions
This doesn't seem right. You're still using a mixture of KService and KPluginInfo just avoiding the warning by parsing everything twice, but not really the point of the warning.
Comment Actions
I'd say this new code makes some assumptions we don't want the KService user code to be doing. Here's some ideas:
- we introduce a KPluginMetaData KService::metaData() const method.
- we un-deprecate the KPluginInfo constructor.
kcmkwin/kwindesktop/main.cpp | ||
---|---|---|
576 | Why did you change how the string is constructed? |
Comment Actions
Why had the KPluginInfo(KService) constructor been deprecated? (please ignore it)
kcmkwin/kwindesktop/main.cpp | ||
---|---|---|
576 | IMHO, that's more cleaner. But, yeah, that's most likely unrelated change. |