Diff Detail
- Repository
- R52 KDevelop: PHP Support
- Branch
- 5.0
- Lint
No Linters Available - Unit
No Unit Test Coverage
Those two are deleted through QObject-relationship, aren't they? Both objects are children of the LanguageSupport instance.
Hmm, I see your point. To put this change in context: I have run KDevelop inside Valgrind since I wanted to debug a crash-on-close problem. Valgrind however showed tons of incomplete deletions of LanguageSupport objects, which vanished after adding these explicit deletes.
Do you think that these Valgrind errors may be caused by having a crash in KDevelop before the QObject children relationships could take care for deleting the m_highlighting and m_refactoring objects?
I see.
Do you think that these Valgrind errors may be caused by having a crash in KDevelop before the QObject children relationships could take care for deleting the m_highlighting and m_refactoring objects?
Likely, yes. I've been running KDevelop under ASAN for a while (with leak reports enabled), and I fixed tons of leaks already. I would have seen this one. You agree that this deletion should be taken care of via QObject relationship, right? In that case, we can abandon this patch.
Leak checking after any kind of abnormal program termination is unreliable. If you saw this after a crash then it would explain this issue.