- More Commented Code.
- AtCore::closeConnection: no longer try to unload a plugin if one was not loaded.
- AtCore Add missing space between functions
- mainpage.md fix for lays kde mail
- Remove AtCore::detectFirmware
Details
- Reviewers
laysrodrigues patrickelectric tcanabrava - Commits
- R232:ca4555e790a2: Various Fixes - AtCore::closeConnection: no longer try to unload a plugin if…
R232:d8497f69cc4e: - Remove AtCore::detectFirmware
R232:50607dca5ff0: AtCore::setIdleHold -> AtCore::disableMotors
R232:f78e2d5a0d3d: More comments
R232:ed95d7eed4de: Now with more comments
Diff Detail
- Repository
- R232 AtCore
- Branch
- moreComments
- Lint
No Linters Available - Unit
No Unit Test Coverage
src/atcore.cpp | ||
---|---|---|
422 | Yes I only put that becuse there is a stop for print job and a stop for sd prints. The code is very simple and does not require commenting. | |
452 | Yes I only put that becuse there is a stop for print job and a stop for sd prints. The code is very simple and does not require commenting. | |
693 | Disable Motors is done with a different Code this code is more commonly supported. There is no reason the function name can't be changed to AtCore::disableMotors. |
src/atcore.cpp | ||
---|---|---|
422 | ok makes sense. |
src/atcore.cpp | ||
---|---|---|
287 | Why keep timer in memory if were not going to use it? |
src/atcore.cpp | ||
---|---|---|
146 | firmwares*, 'start', they firmware string name | |
287 | because allocating and deallocating memory is worse than maintaining | |
347–349 | The thread will handle the gcode file without freezing the library. | |
365 | //Append command to the commands queue. | |
446 | throught* | |
522 | Push*, coordinates. | |
700 | boot. |
src/atcore.cpp | ||
---|---|---|
446 | through** |
src/atcore.cpp | ||
---|---|---|
349 | is ready, avoiding buffer overflow in the printer. | |
365 | I'm not a native english speaker, but this "on to the" is correct ? shouldn't it be only "to the" ? | |
377–378 | What is clean print ? print is a variable ? I can't get what you are saying here only reading the comment. This need to be restructured. | |
523 | This will be* | |
src/atcore.h | ||
396 | The brief already have the exactly same text, this line should be removed. |