Differential D10984

Added copy to clipboard in background/dbus mode
Needs ReviewPublic
Actions

Authored by kavindap on Mar 3 2018, 4:11 AM.

Details

Reviewers
None
Group Reviewers
Spectacle
Summary

I added an CLI option for copying to clipboard in background/dbus modes.

Depends on D9117

FEATURE: 385559

Test Plan

Execute " spectacle -bc "

Expected result:

Screenshot copied to clipboard.

Note:
As linux empties clipboard on application exit, use klipper with 'ignore images' unchecked.

Diff Detail

Repository
R166 Spectacle
Branch
CLIClipboard
Lint
No Linters Available
Unit
No Unit Test Coverage
kavindap requested review of this revision.Mar 3 2018, 4:11 AM
kavindap created this revision.
kavindap edited the summary of this revision. (Show Details)Mar 3 2018, 4:26 AM
kavindap edited the summary of this revision. (Show Details)Mar 3 2018, 4:42 AM
kavindap edited the test plan for this revision. (Show Details)
rkflx added a subscriber: rkflx.EditedMar 3 2018, 7:58 AM

Thanks for your contribution ;) Summary and test plan look nice.

Did not look too much at the code yet, but the bug you mentioned (eventually) links to a similar Diff touching the same topic, see D9117: Add shortcuts for copying screenshots to clipboard. I wonder if you could base your patch on that (see also here) and here merely add the CLI option? Note that we still might have to change the other Diff a bit, pending code review.

kavindap updated this revision to Diff 28627.Mar 4 2018, 8:23 PM
kavindap edited the summary of this revision. (Show Details)
kavindap edited the test plan for this revision. (Show Details)
This comment was removed by kavindap.
kavindap updated this revision to Diff 28628.Mar 4 2018, 8:27 PM

Depends on D9117

cfeck added a subscriber: cfeck.Mar 30 2018, 3:14 AM
cfeck added inline comments.
src/SpectacleCore.cpp
82

Please add missing spaces at if/else braces.

szafar added a subscriber: szafar.Oct 23 2018, 8:45 AM

+1 Having this would be great!

Restricted Application added a project: Spectacle. · View Herald TranscriptOct 23 2018, 8:45 AM

Revision Contents
Changeset List

PathPackages
Msrc/Main.cpp (8 lines)
Msrc/SpectacleCore.h (2 lines)
Msrc/SpectacleCore.cpp (9 lines)

Diff 28628

View Options

src/Main.cpp

Loading...
View Options

src/SpectacleCore.h

Loading...
View Options

src/SpectacleCore.cpp

Loading...