Polish the design of the review input pop-up:
- Make the button tell you what you need to do
- Make it impossible to accidentally submit a one-star review
BUG: 390426
apol | |
abetts |
Discover Software Store |
Polish the design of the review input pop-up:
BUG: 390426
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
What purpose does the empty space serve?
If it has no purpose then the Review textbox could be larger or the window smaller.
Also is 1 star the default value? Is that a good idea?
The empty space on the bottom is a bug in Kirigami that I fixed this morning with D10502: Eliminate unnecessary bottom padding on OverlaySheets.
The star rating change is a good idea (because yeah, 1 star as the default is a bad idea), just proposed by someone else this morning, in fact: https://bugs.kde.org/show_bug.cgi?id=390426
I can look into that here.
Looks good to me. I would change the hover animation. Most places that use star ratings tend to highlight all stars up to where your cursor is located. It gives the impression that you are also enabling the starts up to your location. If your cursor is in the fourth star, then also highlight the 3 start before it.
That's a good idea, but I'm having a bit of trouble with the implementation. If this is otherwise okay, can we land it in its current state, and commit to doing that in a subsequent patch?