Differential D9424

Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file
ClosedPublic
Actions

Authored by habacker on Dec 20 2017, 9:59 AM.

Details

Reviewers
dfaure
bcooksley
apol
Commits
R268:205b69533bb5: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to…
Summary

BUG:382460
FIXED-IN:5.43.0

Test Plan

compiled against installed build from kdbusaddons git repo master branch

Diff Detail

Repository
R268 KGlobalAccel
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
habacker created this revision.Dec 20 2017, 9:59 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 20 2017, 9:59 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
habacker requested review of this revision.Dec 20 2017, 9:59 AM
apol accepted this revision.Dec 20 2017, 12:32 PM
apol added a subscriber: apol.
apol added inline comments.
src/runtime/CMakeLists.txt
66–73

I would add here #we need a relocatable kglobalaccel5 executable for WIN32

This revision is now accepted and ready to land.Dec 20 2017, 12:32 PM
apol requested changes to this revision.Dec 20 2017, 12:35 PM

Wait, why is this needed all of a sudden? Aren't these services used in the rest of win32 applications we have available in https://binary-factory.kde.org/?

This revision now requires changes to proceed.Dec 20 2017, 12:35 PM
habacker added a comment.Dec 20 2017, 3:31 PM

I stumbled over one issue case and did a quick search which locations are also affected by this issue type.

habacker updated this revision to Diff 24168.Dec 20 2017, 3:33 PM
  • added note
habacker marked an inline comment as done.Dec 20 2017, 3:34 PM
apol added a subscriber: Windows.Dec 20 2017, 3:57 PM
apol added subscribers: vonreth, kfunk.

@kfunk, @vonreth Will craft applications also benefit from this? Or is it solved in a different way there?

kfunk added a comment.Dec 20 2017, 4:44 PM

Please let's discuss on https://phabricator.kde.org/D9423 exclusively. This is basically fixing the same issue in a different repository.

habacker updated this revision to Diff 25187.Jan 11 2018, 9:27 PM
  • Use cmake macro from kdbusaddons git repo
  • Set FIXED-IN version to 5.43.0 because it requires kdbusaddons version 5.43.0
habacker retitled this revision from Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows' to Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file.Jan 11 2018, 9:29 PM
habacker edited the summary of this revision. (Show Details)
habacker edited the test plan for this revision. (Show Details)
In D9424#181538, @apol wrote:

@kfunk, @vonreth Will craft applications also benefit from this?

yes

Or is it solved in a different way there?

no

dfaure accepted this revision.Jan 12 2018, 8:40 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 12 2018, 9:07 AM
Closed by commit R268:205b69533bb5: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to… (authored by habacker). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24168

View Options

src/runtime/CMakeLists.txt

Loading...
View Options

src/runtime/org.kde.kglobalaccel.service.win.in

Loading...