MessageInterface: Add CenterInView as additional position
ClosedPublic

Authored by dhaumann on Dec 18 2017, 10:50 AM.

Details

Summary

This patch extends the message interface to support CenterInView.
This should be binary compatible, since an enum is only added at
the end. In order to support this, a custom layout called
KateMessageLayout was added that only supports the floating
positions allowed by KTextEditor::Message::MessagePosition.

Upadte unit test, it seems the window size was too small for
the MessageTest.

Test Plan

make test

Diff Detail

Repository
R39 KTextEditor
Branch
MessageInterface (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
dhaumann created this revision.Dec 18 2017, 10:50 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 18 2017, 10:50 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dhaumann requested review of this revision.Dec 18 2017, 10:50 AM

@cullmann This patch now only adds the CenterInView, nothing else (i.e. no changes in search code). Now good to go?

dhaumann updated this revision to Diff 24059.Dec 18 2017, 11:01 AM
  • Add @since 5.42

Jup, ok ;)

The 5 as size is still bit strange, but as we have no end enum value, which we don't want to be BC, I guess that is no issue.

cullmann accepted this revision.Dec 18 2017, 11:03 AM
This revision is now accepted and ready to land.Dec 18 2017, 11:03 AM
This revision was automatically updated to reflect the committed changes.