Hints will be added to the activity ascending_order, to be toggled on or off for easier comprehension of the objective by the user.
Details
Diff Detail
- Repository
- R2 GCompris
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Setting base as original changes in acitivities ascending_order and alphabetical_order
Had a quick look at the overall working of the activities, few thoughts:
- The hints should only be for the alphabetical ordering activity and not for the ascending order activity (to be confirmed with @jjazeix ) (since the numbers can be infinite, and the numbers can be > 9).
- The hints should be turned off by default (when the activity starts) so that the user only views it when they are stuck
src/activities/ascending_order/Ascending_order.qml | ||
---|---|---|
102 | This will only be showing the 0 - 9 hints for the alphabetical ordering as well. Use the "letters" variable to display the hints: var letters = qsTr("a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z") |
No need to delete the alphabetical_order activity. What I meant was: everything in pull/172 + a GCText element containing the hints (which is there) + the hint bar button will only be available for alphabetical ordering activity only.
Few things:
- the src/activities/activities.txt file was not added
- can you also add the alphabetical_order activity (from here: https://github.com/gcompris/GCompris-qt/pull/172/files) along with this diff?
@jjazeix Hi, I wanted to ask if I can go ahead with implementing the features than Allon asked in the pull link, so that I can work on it for SoK. Thanks.
There are the comments made on May 16 on github (https://github.com/gcompris/GCompris-qt/pull/172) to fix.
Can you also update the qml import to use the same as the other activities and adding in the ActivityInfo.qml the translator helpers (like in https://github.com/gcompris/GCompris-qt/blob/master/src/activities/advanced_colors/ActivityInfo.qml#L26)?
Changes made as requested. Also all files in the pull included in the diff. Please review.
The hint should have a better displaying. Just displaying the list of letters without any explanation is not helping.
The letters overrides with the score on small screens.
Switching from ascending order to descending in the same level is confusing
Thanks for the review. I will be working on the hints display for ascending order in my SoK, in case my proposal is approved. So keeping the changes for that.