Adding hints to ascending_order (to be implemented in alphabetical_order as well)
AbandonedPublic

Authored by rohitdas on Oct 28 2017, 4:44 AM.

Details

Reviewers
None
Group Reviewers
GCompris
GCompris: Improvements
Summary

Hints will be added to the activity ascending_order, to be toggled on or off for easier comprehension of the objective by the user.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
rohitdas created this revision.Oct 28 2017, 4:44 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptOct 28 2017, 4:44 AM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
rohitdas retitled this revision from Adding hints to ascending_order (to be implemented in alphabet_order as well) to Adding hints to ascending_order (to be implemented in alphabetical_order as well).Oct 28 2017, 4:45 AM
rohitdas updated this revision to Diff 21467.Oct 28 2017, 6:15 AM

Adding changes to src/activities/activities.txt

rohitdas updated this revision to Diff 21468.Oct 28 2017, 6:28 AM

Setting base as original changes in acitivities ascending_order and alphabetical_order

Had a quick look at the overall working of the activities, few thoughts:

  • The hints should only be for the alphabetical ordering activity and not for the ascending order activity (to be confirmed with @jjazeix ) (since the numbers can be infinite, and the numbers can be > 9).
  • The hints should be turned off by default (when the activity starts) so that the user only views it when they are stuck
src/activities/ascending_order/Ascending_order.qml
102

This will only be showing the 0 - 9 hints for the alphabetical ordering as well. Use the "letters" variable to display the hints:

var letters = qsTr("a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z")
rohitdas updated this revision to Diff 21470.Oct 28 2017, 7:23 AM

Changes made as suggested. Please review.

No need to delete the alphabetical_order activity. What I meant was: everything in pull/172 + a GCText element containing the hints (which is there) + the hint bar button will only be available for alphabetical ordering activity only.

rohitdas updated this revision to Diff 21569.Oct 30 2017, 2:11 PM

Hints appear only in alphabetical order. Please review.

Few things:

@jjazeix Hi, I wanted to ask if I can go ahead with implementing the features than Allon asked in the pull link, so that I can work on it for SoK. Thanks.

There are the comments made on May 16 on github (https://github.com/gcompris/GCompris-qt/pull/172) to fix.
Can you also update the qml import to use the same as the other activities and adding in the ActivityInfo.qml the translator helpers (like in https://github.com/gcompris/GCompris-qt/blob/master/src/activities/advanced_colors/ActivityInfo.qml#L26)?

rohitdas updated this revision to Diff 23944.Dec 15 2017, 5:00 AM

Changes made as requested. Also all files in the pull included in the diff. Please review.

rohitdas updated this revision to Diff 23945.Dec 15 2017, 5:09 AM

Changes made as requested. Also all files from the pull added. Please review.

jjazeix added inline comments.Dec 16 2017, 2:17 PM
src/activities/alphabetical_order/ActivityInfo.qml
26 ↗(On Diff #23945)

qsTr()

29 ↗(On Diff #23945)

Arranging

32 ↗(On Diff #23945)

reading

src/activities/alphabetical_order/Alphabetical_order.qml
22 ↗(On Diff #23945)

2.6

src/activities/ascending_order/ActivityInfo.qml
31

there should not be the ":" here

The hint should have a better displaying. Just displaying the list of letters without any explanation is not helping.
The letters overrides with the score on small screens.
Switching from ascending order to descending in the same level is confusing

Thanks for the review. I will be working on the hints display for ascending order in my SoK, in case my proposal is approved. So keeping the changes for that.

rohitdas abandoned this revision.Jan 18 2018, 8:52 AM