Details

Reviewers

rizzitello
tcanabrava
patrickelectric

Summary

The use of QLatin1String is more optimized than
QStringLiteral.
This tip was given by Lamarque and the doc follows:
http://doc.qt.io/qt-5/qlatin1string.html#details

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Diff Detail

Repository

R232 AtCore

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

laysrodrigues created this revision.Jun 10 2017, 4:41 PM

Change more files

patrickelectric requested changes to this revision.Jun 10 2017, 5:01 PM

patrickelectric added inline comments.

src/atcore.cpp
84	the operator+ don't have a overload to QString, moving to QLatin1String don't make sense.
432	in args we can use qbytearray and here qbytearrayliteral
src/plugins/aprinterplugin.cpp
32	QLatin1String will be converted to QString in runtime, change it back to QStringLiteral.
38	Same here.. Check all the changes, and only use QLatin with the ones that will not be converted to QString.

This revision now requires changes to proceed.Jun 10 2017, 5:01 PM

patrickelectric added inline comments.Jun 10 2017, 5:02 PM

src/atcore.cpp
84	the operator+ don't have a overload to QString from QLatin1String, moving to QLatin1String don't make sense.

Updating the changes

Update patrick changes

laysrodrigues added inline comments.Jun 11 2017, 3:37 PM

src/atcore.cpp
432	use of QByteArray here is breaking the build. /home/lays/programs/atcore/core/src/atcore.cpp:435: error: ‘QString::QString(const QByteArray&)’ is private within this context args.append(QByteArrayLiteral("X0 ")); ^ I moved back to QStringLiteral

Fix error using QByteArray

patrickelectric requested changes to this revision.Jun 11 2017, 3:48 PM

patrickelectric added inline comments.

src/atcore.cpp
380	remove don't have a overload to remove and QLatin1String..
src/atcore_default_folders.h.in
27–30	Another case that need conversion to QString.. Please.. check the doc before performing such change :)

This revision now requires changes to proceed.Jun 11 2017, 3:48 PM

Update last patrick comments

I used search and replace in all files, didn't pay attention
to the details that you are highlighting. =/

Possibly more places to revert, anywhere it will be cast as QString QStringLiteral should be used.

src/atcore_default_folders.h.in
26–27	QStringList, revert to QStringLiteral
src/gcodecommands.cpp
94	Function returns QString, revert the returns to QStringLiteral
130	Function Returns QString , revert to QStringLiteral
src/seriallayer.cpp
34–35	QStringlist , revert to QStringLiteral

rizzitello requested changes to this revision.Jun 13 2017, 1:47 PM

This revision now requires changes to proceed.Jun 13 2017, 1:47 PM

More fixes

patrickelectric requested changes to this revision.Jun 13 2017, 4:09 PM

patrickelectric added inline comments.

src/temperature.cpp
92–93	Again... Check if the class accept QLatin1String. Not for only this line, but for the entire diff.

This revision now requires changes to proceed.Jun 13 2017, 4:09 PM

laysrodrigues abandoned this revision.Oct 31 2017, 11:25 AM

			Path	Packages
M			src/atcore.cpp (18 lines)
M			src/atcore_default_folders.h.in (8 lines)
M			src/gcodecommands.cpp (28 lines)
M			src/plugins/aprinterplugin.cpp (4 lines)
M			src/plugins/grblplugin.cpp (2 lines)
M			src/plugins/marlinplugin.cpp (4 lines)
M			src/plugins/repetierplugin.cpp (4 lines)
M			src/plugins/smoothieplugin.cpp (4 lines)
M			src/plugins/sprinterplugin.cpp (4 lines)
M			src/plugins/teacupplugin.cpp (4 lines)
M			src/seriallayer.cpp (24 lines)
M			src/temperature.cpp (16 lines)
M			testclient/main.cpp (6 lines)
M			testclient/mainwindow.cpp (40 lines)
M			testclient/widgets/plotwidget.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15334	03559bd		Jun 10 2017, 4:41 PM	★	★
Diff 2	15336	03559bd	Change more files	Jun 10 2017, 4:49 PM	★	★
Diff 3	15351	66914e0	Update patrick changes	Jun 11 2017, 3:34 PM	★	★
Diff 4	15352	66914e0	Fix error using QByteArray	Jun 11 2017, 3:37 PM	★	★
Diff 5	15422	66914e0	Update last patrick comments	Jun 13 2017, 1:37 PM	★	★
Diff 6	15425	66914e0	More fixes	Jun 13 2017, 3:03 PM	★	★

Use of QLatin1String instead of QStringLiteral
AbandonedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 15336

src/atcore.cpp

src/atcore_default_folders.h.in

src/gcodecommands.cpp

src/plugins/aprinterplugin.cpp

src/plugins/grblplugin.cpp

src/plugins/marlinplugin.cpp

src/plugins/repetierplugin.cpp

src/plugins/smoothieplugin.cpp

src/plugins/sprinterplugin.cpp

src/plugins/teacupplugin.cpp

src/seriallayer.cpp

src/temperature.cpp

testclient/main.cpp

testclient/mainwindow.cpp

testclient/widgets/plotwidget.cpp

Use of QLatin1String instead of QStringLiteralAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 15336

src/atcore.cpp

src/atcore_default_folders.h.in

src/gcodecommands.cpp

src/plugins/aprinterplugin.cpp

src/plugins/grblplugin.cpp

src/plugins/marlinplugin.cpp

src/plugins/repetierplugin.cpp

src/plugins/smoothieplugin.cpp

src/plugins/sprinterplugin.cpp

src/plugins/teacupplugin.cpp

src/seriallayer.cpp

src/temperature.cpp

testclient/main.cpp

testclient/mainwindow.cpp

testclient/widgets/plotwidget.cpp

Use of QLatin1String instead of QStringLiteral
AbandonedPublic
Actions

Revision Contents
Changeset List