Differential D5996

Fix Buildig on Mac Os
ClosedPublic
Actions

Authored by rizzitello on May 28 2017, 1:39 AM.

Details

Reviewers
laysrodrigues
patrickelectric
tcanabrava
Commits
R232:04e61e28b093: Set plugin path on mac os to .app/Contents/MacOs/plugins
R232:a87f2931b6d6: Stop Crash on Mac os due to setting menu entry to theme icon
R232:97e519684b48: Setup mac os install
Summary

Set up the required things to build AtCore on mac os
Still needs to have plugins copied to .app/Contents/MacOs/plugins manually
and may need addition to be portable between systems

Diff Detail

Repository
R232 AtCore
Branch
fixMacOS
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello created this revision.May 28 2017, 1:39 AM
rizzitello updated this revision to Diff 14903.May 28 2017, 2:11 AM
  • Setup mac os install
patrickelectric added inline comments.May 29 2017, 2:28 PM
src/atcore.cpp
80–81

if defined(Q_OS_WIN) || defined(Q_OS_MAC)

testclient/CMakeLists.txt
35

else

rizzitello updated this revision to Diff 14954.May 29 2017, 9:05 PM
  • Added Patricks suggestions
rizzitello updated this revision to Diff 14956.May 29 2017, 9:09 PM
  • Stop Crash on Mac os due to setting menu entry to theme icon
  • Set plugin path on mac os to .app/Contents/MacOs/plugins
  • Setup mac os install
  • Patricks additions
  • rebase to master
patrickelectric accepted this revision.May 29 2017, 9:55 PM
This revision is now accepted and ready to land.May 29 2017, 9:55 PM
Closed by commit R232:a87f2931b6d6: Stop Crash on Mac os due to setting menu entry to theme icon (authored by rizzitello). · Explain WhyMay 30 2017, 1:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 14954

View Options

CMakeLists.txt

Loading...
View Options

src/atcore.cpp

Loading...
View Options

src/plugins/CMakeLists.txt

Loading...
View Options

testclient/CMakeLists.txt

Loading...
View Options

testclient/mainwindow.cpp

Loading...
View Options

testclient/mainwindow.ui

Loading...
View Options

testclient/widgets/CMakeLists.txt

Loading...