Show "portname (unavailable)" in port list if a port is not available.
BUG: 377193
davidedmundson |
Plasma |
Show "portname (unavailable)" in port list if a port is not available.
BUG: 377193
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Would it make sense to disable (in the ContextMenu) and/or filter out those ports instead? Or is this so you can configure it to play on headphones and once you plug them in it will work? Not sure about the "unavailable" prefix.
src/kcm/package/contents/ui/DeviceListItem.qml | ||
---|---|---|
84 | You could also just use a JS Array for this since you're not making use of ListModel's binding capabilities (you always clear and re-populate the model) | |
91 | Better cache port as variable: var port = ports[i]; ... |
Use same wording as pavucontrol - unavailable only for internal devices, unplugged otherwise
Would it make sense to disable (in the ContextMenu) and/or filter out those ports instead? Or is this so you can configure it to play on headphones and once you plug them in it will work?
I don't think we should filter/disable it, because if you plug it in, it will play from this port.