I just realized there was a weird workaround in plasma-nm where it gets
checked so it's shown.
Properly use the declarative API instead of listening to a ton of signals.
Details
- Reviewers
mart - Group Reviewers
Plasma - Commits
- R242:54e87fe879ba: Make sure we display enabled ListItem on hover
Tested with plasma-nm and org.kde.plasma.notifications plasmoids
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Concept seems fine. New binding has some typos
src/declarativeimports/plasmacomponents/qml/ListItem.qml | ||
---|---|---|
97 | why are you now following containsMouse. That's a behavioural change How can background.pressed be true. I don't see where it exists? |
src/declarativeimports/plasmacomponents/qml/ListItem.qml | ||
---|---|---|
97 | Yes, I meant to put itemMouse.pressed. I wonder why QML doesn't complain... It's barely a behavioral change, in fact it's what it was supposed to happen in the first place: give feedback on hover when the item is clickable. |
src/declarativeimports/plasmacomponents/qml/ListItem.qml | ||
---|---|---|
97 |
We have the highlight for the item under mouse. |
src/declarativeimports/plasmacomponents/qml/ListItem.qml | ||
---|---|---|
97 | If that's the case, then we should remove the opacity change on hover altogether then. |
src/declarativeimports/plasmacomponents/qml/ListItem.qml | ||
---|---|---|
97 | when the item contains the mouse the prefix shouldn't be "pressed" |