canal_lock, fix lock overriding.
Closed, ResolvedPublic

Description

On some widdescreen and square screens, the left canal lock gets completely hidden by the bar making it un-playable.

Screenshot of the issue: https://pasteboard.co/HgyTwvF.png

rohitdas claimed this task.Apr 19 2018, 4:34 AM
rohitdas added a subscriber: jjazeix.EditedApr 19 2018, 5:27 AM

@jjazeix Hi. I am finding some weird behaviour not just in this activity, but in the whole gcompris. I merged the latest updates in master. I run gcompris on KDE in vbox. Now resizing the vbox window simulates screens of various sizes. Now, if I start the activity in full screen, the icons and other scalable graphics remain big, and only scale on width. But, if I resize the window to a smaller size, the icons remain small, and don't grow bigger as I increase window size. Is it the vbox, or gcompris? I am attaching few screenshots to show what I mean.
1.1 Starting activity in full screen: https://pasteboard.co/Hhi26l3.png
1.2 Resizing window after previous start: https://pasteboard.co/Hhi2k4rD.png
2.1 Starting activity in resized window: https://pasteboard.co/Hhi2GZz.png
2.2 Resizing to full screen: https://pasteboard.co/Hhi2QEJ.png

This is the case with the whole of gcompris, not just this activity.

timotheegiet added a subscriber: timotheegiet.EditedApr 19 2018, 8:33 AM

I think this is quite normal when resizing the whole vbox window, since as you said it changes the actual virtual screen size.
Looks like some values are initialized at launch depending on the actual screen size.

Just resizing a window doesn't produce this issue. You can maybe try, keep your vbox fullscreen, and replicate the same tests. At least buttons should always have same size.

jjazeix removed rohitdas as the assignee of this task.May 5 2018, 10:59 AM
jjazeix added a subscriber: rohitdas.
timotheegiet closed this task as Resolved.Jun 16 2020, 6:18 PM

Fixed in commit 5cd004f6168756b3249118d2cbfd814ad88f681d

jjazeix moved this task from Backlog to Done on the GCompris: Improvements board.Jul 5 2020, 1:59 PM