Blacklist KIO on KDE CI for Android, incl. pulled in as dep
Closed, ResolvedPublic

Description

https://invent.kde.org/frameworks/kio/-/blob/master/metainfo.yaml dies not list Android as supported platform, and accordingly KDE CI also has no individual build configured for it on https://build.kde.org/job/Frameworks/job/kio/

It seems though that in the Android Deps buils KIO is pulled in as dependency, which currently results in a broken build as KIO has code not biuld-compatible with Android -> https://build.kde.org/view/Failing/job/Administration/job/Dependency%20Build%20Applications%20stable-kf5-qt5%20AndroidQt5.15/

I have no insight, but from what I remember to have seen, KIO on Android is nothing someone is really interested in?

So could KDE CI somehow blacklist KIO when calculating the deps of products for Android platform?

kossebau created this task.Jul 15 2021, 1:00 PM
Restricted Application added a subscriber: sysadmin. · View Herald TranscriptJul 15 2021, 1:00 PM

There certainly is interest in having KIO functional on Android, but currently that's not the case and won't be for the foreseeable future.

KIO usually builds fine for Android (at least with the hack that enables QtDBus for Android that the CI has), but it's not very useful to have at runtime and most of our Android apps avoid it as a dep, partly because the craft-based binary-factory setup lacks that hack

I couldn't find a reason for KIO being newly pulled into the dependency build, and it turns out it has always been there, there's just a build breakage due to recent KIO changes. Might be easier to fix that than dealing with the hard to calculate fallout of pulling KIO out of the middle of the dependency chain.

Okay, sounds like "not really, but then somehow" ;)

I conclude that the KDE-Android project then assumes KIO is kept buildable at least. To ensure that it then would be good to have the normal KIO CI biulds also be done for Android, so those doing changes have a chance to learn in time if they broke something, and others are not caught by bad surprises only on the next Deps build. Makes sense?

If you agree, I would ask then Ben to instead enable Android platform for the normal KIO builds.

Also should we add a respective note to the metainfo.yaml file. Perhaps

- name:  Android
  note: Not yet functional, WIP

When something breaks, it should be best fixed immediately, when people are still around and have things in their mind. Having Deps builds breaking days later not only sucks because that usually means more work to have it done again, but also is annoying when one has to track down those who could fix things. Better be avoided when we can.

https://invent.kde.org/frameworks/kio/-/merge_requests/505 should fix this

Regarding adding KIO to the CI: valid arguments, but that equally applies to all other frameworks being pulled into the dependency build that are not covered by the CI at this point as well, KIO isn't special there.

So you propose to just leave the status quo or to add also all the others? My intention here was to help the KDE-Android project by not having their Deps build fail now and then (and then those who care to keep CI in green/blue sate), but the passive reaction so far on principle changes makes me feel there is no interest? Just say, todo has me lots of other things to do :)

I don't mind this being changed, my point is that touching that part of the CI tends to have unforeseen side-effects, so better be prepared for that :)

So to confirm what we are doing here - add KIO to Android CI?

Given Android Deps build faild again in KIO, and given that there seems no interest/resources to invest into making KIO a proper optional dependency for the apps build for Android, I propose to just add KIO to the Android CI instead, even more as KIO is large and there are lots of changes and thus changes to break the Android build.

See also https://build.kde.org/view/Failing/job/Administration/job/Dependency%20Build%20Applications%20kf5-qt5%20AndroidQt5.15/lastFailedBuild/console

Will not pursue further though, pulling out here.

bcooksley closed this task as Resolved.Aug 4 2021, 9:30 AM
bcooksley claimed this task.

I've now enabled KIO on Android CI.