Create Task
Maniphest T1147

Fix build for kcalcore - missing ktimezoned
Closed, WontfixPublic
Actions

Description

Currently kcalcore tests are failing. I can reproduce this problem also in my docker installation if I have no ktimezoned running.

So we need for the tests:

  • kded5 running
  • kded5 must find ktimezone

if the tests are afterwards still failing please run one test by hand and paste the full output:

/home/jenkins/builds/kcalcore/stable-kf5-qt5/build/autotests/testrecurrence /home/jenkins/builds/kcalcore/stable-kf5-qt5/kcalcore/autotests/data/RecurrenceRule/UntilInUTC/Until_TestCase06.ics
knauss created this task.Dec 8 2015, 12:43 PM
knauss updated the task description. (Show Details)
knauss raised the priority of this task from to Normal.
knauss added a project: build.kde.org.
knauss added subscribers: knauss, smartins, KDE PIM.
scarlettclark added a subscriber: scarlettclark.Dec 11 2015, 10:11 PM

hmm the only ktimezoned I can find is in plasma-workspace? https://github.com/KDE/plasma-workspace/tree/master/ktimezoned

kcalcore needs to depend on plasma-workspace then? Please confirm, something doesn't seem right there.

scarlettclark raised the priority of this task from Normal to High.Dec 11 2015, 10:12 PM
knauss added a comment.Dec 11 2015, 11:50 PM

as far as i found inthegit logs, yes ktimezond is now moved to plasma-workspace and this is needed for the tests of kcalcore.

kcalcore needs to depend on plasma-workspace then?

well not really - ktimezond is only needed as runtime dependency for the tests.

But yes we should discuss with the plasma guys , that we need to move ktimezond away from plasma.

dvratil added a subscriber: dvratil.Dec 12 2015, 12:02 AM

I guess that's an inheritance from KDELibs4Support? Once we move KCalCore away from KDateTime, we should get rid of the ktimezone dependency...

scarlettclark added a project: Plasma.Dec 12 2015, 8:11 PM

Adding plasma guys.

knauss added a comment.Dec 27 2015, 2:16 PM

can we please just add ktimezond to prove that this is really the problem - otherwise we have to search deeper.

dvratil added a comment.Dec 28 2015, 11:57 AM

Maybe you could try to temporarily add plasma-workspace to kde-build-metadata for kcalcore? Then manually trigger a build on CI, see what happens and revert the kde-build-metadata. Depending on whether it helps or not, we can try to figure out what to do.

Obviously having a runtime dependency on ktimezoned in kcalcore is a bad thing and prevents us from ever making it a proper framework.

scarlettclark added a comment.Jan 12 2016, 8:37 PM

Sorry for taking so long, behind due to holidays. Adding plasma-workspace did indeed do the trick fixing 114 tests.

https://build-sandbox.kde.org/job/kcalcore%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/3/

dvratil added a comment.Jan 15 2016, 11:08 PM

Having the dependency on the CI is one thing, but does the software actually work without the kded daemon properly for our users (who don't have plasma-workspace installed)?

knauss added a comment.Jan 17 2016, 4:10 PM

dvratil: you are right, without ktimezond users can't use timezones so far. The base problem is gone, if we replace KDateTime with QDateTime. With QDateTime the handling of timezones is done inside qt.

jriddell edited projects, added KDE PIM; removed Plasma.Mar 31 2016, 11:46 AM
scarlettclark added a comment.Apr 13 2016, 7:48 PM

What is the status on this, is there something I am suppose to be doing?

Cheers,
Scarlett

knauss closed this task as Wontfix.Apr 13 2016, 10:04 PM
knauss claimed this task.

well as i said for tests it would be nice to have ktimezond available, but with the way this dependency was added a circular dependency was introduced.

The current status is that John Layt is replaying KDateTime with QDateTime etc. So let's live with this yellow job till his work will be merged to master.