Review KateGotoBar

Authored by loh.tar on Jan 17 2019, 12:03 PM.

Description

Review KateGotoBar

Summary:

  • Set minimum value of spin-box to 1
  • Update spinbox boundaries in rare cases where the bar is visible while document is edited
  • Don't force minimum width by buttons, see similar Bug 402904
  • Rename gotoRange -> m_gotoRange
  • Add modified_line_up/down buttons with mouse wheel support
  • Change label text to be less redundant in conjunction with the "goto-button"
  • Change QLabel to button, with an action to go to line number from clipboard. My first intend was to add a clear-button to the spin box (not so easy) because paste from clipboard needs an empty field. But then I had this idea which is much more handy.

Test Plan:

Reviewers: KTextEditor, cullmann

Reviewed By: KTextEditor, cullmann

Subscribers: dhaumann, cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, KTextEditor

Tags: Kate, Frameworks

Differential Revision: https://phabricator.kde.org/D18164

Details

Committed
cullmannJan 17 2019, 12:04 PM
Reviewer
KTextEditor
Differential Revision
D18164: Review KateGotoBar
Parents
R39:1e0ace28c795: ViewInternal: Fix 'Go to matching bracket' in override mode
Branches
Unknown
Tags
Unknown