Fix: View jumps when Scroll past end of document is enabled

Authored by dhaumann on Jan 23 2018, 5:26 PM.

Description

Fix: View jumps when Scroll past end of document is enabled

Summary:
This patch fixes a corner case for the following setup:

  • enable "[x] Scroll past end of document"
  • disable dynamic word wrap (i.e. you see a horizontal scrollbar for long lines)
  • open a document with several lines
  • make sure the last line is NOT empty

Let's say the last two lines look as follows

yy|yy # '|' denoes the cursor position
zzzzz

Make sure you scrolled past the end of the document (either
with the mouse or with Ctrl+Down). Note that line 'zzzzz' is
completely visible.

Now press 'cursor down'.

What happens is that the view contents jumps and the scrolling
behavior acts as if "Scroll past end of document" is not enabled.

Expected behavior is that the cursor position goes one line down,
but the scroll position remains completely unchanged.

The bug here is the following if clause:

} else if (c > viewLineOffset(startPos(), linesDisplayed() - m_minLinesVisible - 1)) {
    KTextEditor::Cursor scroll = viewLineOffset(c, -(linesDisplayed() - m_minLinesVisible - 1));
    scrollPos(scroll, false, calledExternally);
}

In the buggy case, c==(28, 1), and viewLineOffset()==(28,0).
This triggers the bug that in the last line of the document for
columns > 0 the scroll position is adapted.

The proposed fix here is to not compare cursor positions, but only
the lines. Clearly, 28 < 28 is not true, leading to no change in
the scroll position.

BUG: 306745
FIXED-IN: KDE Frameworks 5.43

Test Plan: make test

Reviewers: cullmann

Reviewed By: cullmann

Subscribers: Frameworks

Tags: Kate, Frameworks

Differential Revision: https://phabricator.kde.org/D10054

Details

Committed
dhaumannJan 24 2018, 5:53 PM
Reviewer
cullmann
Differential Revision
D10054: Fix: View jumps when Scroll past end of document is enabled
Parents
R39:fbdfe779e46c: KateView unit test: simplify finding KateViewInternal
Branches
Unknown
Tags
Unknown