Fix a multiple template instantiation problem on Windows and OSX
b11e516c1b87
Actions

Authored by dkazakov on Sep 7 2016, 10:54 AM.

Description

Fix a multiple template instantiation problem on Windows and OSX

Summary:
This patch should fix the crash that happens on some versions of
Windows and OSX. The problem is that the templates are instantated in
different libraries and, therefore, dynamic_cast<> considers them to be
different types of objects

Test Plan: Compile and try to use Brush HUD

Reviewers: rempt, Krita

Reviewed By: rempt, Krita

Differential Revision: https://phabricator.kde.org/D2692

Details

Committed

rempt

Sep 27 2016, 9:52 AM

Reviewer

Krita

Differential Revision

D2692: Fix a multiple template instantiation problem on Windows and OSX

Parents

R37:0c10a7081a20: Update version number

Branches

Unknown

Tags

Unknown

rempt committed R37:b11e516c1b87: Fix a multiple template instantiation problem on Windows and OSX (authored by dkazakov).Sep 27 2016, 9:52 AM

Changes (16)

				Path	Packages
	M			libs/image/CMakeLists.txt
	M			libs/image/brushengine/kis_combo_based_paintop_property.cpp
	M			libs/image/brushengine/kis_combo_based_paintop_property.h
	P			libs/image/brushengine/kis_slider_based_paintop_property.cpp Copied from libs/image/brushengine/kis_no_size_paintop_settings.h
	M			libs/image/brushengine/kis_slider_based_paintop_property.h
	M			libs/image/brushengine/kis_uniform_paintop_property.cpp
	M			libs/image/brushengine/kis_uniform_paintop_property.h
	M			plugins/paintops/colorsmudge/kis_colorsmudgeop_settings.cpp
	M			plugins/paintops/curvebrush/kis_curve_paintop_settings.cpp
	M			plugins/paintops/defaultpaintops/duplicate/kis_duplicateop_settings.cpp
	M			plugins/paintops/deform/kis_deform_paintop_settings.cpp
	M			plugins/paintops/dynadraw/kis_dyna_paintop_settings.cpp
	M			plugins/paintops/experiment/kis_experiment_paintop_settings.cpp
	M			plugins/paintops/gridbrush/kis_grid_paintop_settings.cpp
	M			plugins/paintops/libpaintop/kis_brush_based_paintop_settings.cpp
	M			plugins/paintops/spray/kis_spray_paintop_settings.cpp