Fix a multiple template instantiation problem on Windows and OSX
ClosedPublic
Actions

Authored by dkazakov on Sep 7 2016, 10:56 AM.

Details

Reviewers

Group Reviewers

Commits

R37:c85417457a3c: Fix a multiple template instantiation problem on Windows and OSX
R37:b11e516c1b87: Fix a multiple template instantiation problem on Windows and OSX

Summary

This patch should fix the crash that happens on some versions of
Windows and OSX. The problem is that the templates are instantated in
different libraries and, therefore, dynamic_cast<> considers them to be
different types of objects

Test Plan

Compile and try to use Brush HUD

Diff Detail

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dkazakov updated this revision to Diff 6511.Sep 7 2016, 10:56 AM

dkazakov retitled this revision from to Fix a multiple template instantiation problem on Windows and OSX.

dkazakov updated this object.

dkazakov edited the test plan for this revision. (Show Details)

dkazakov added reviewers: Krita, rempt.

Works! Yay!

This revision is now accepted and ready to land.Sep 7 2016, 12:28 PM

Closed by commit R37:c85417457a3c: Fix a multiple template instantiation problem on Windows and OSX (authored by dkazakov). · Explain WhySep 7 2016, 1:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		libs/image/CMakeLists.txt (1 line)
M		libs/image/brushengine/kis_combo_based_paintop_property.h (4 lines)
M		libs/image/brushengine/kis_combo_based_paintop_property.cpp (13 lines)
M		libs/image/brushengine/kis_slider_based_paintop_property.h (28 lines)
A	M	libs/image/brushengine/kis_slider_based_paintop_property.cpp (27 lines)
M		libs/image/brushengine/kis_uniform_paintop_property.h (8 lines)
M		libs/image/brushengine/kis_uniform_paintop_property.cpp (10 lines)
M		plugins/paintops/colorsmudge/kis_colorsmudgeop_settings.cpp (2 lines)
M		plugins/paintops/curvebrush/kis_curve_paintop_settings.cpp (1 line)
M		plugins/paintops/defaultpaintops/duplicate/kis_duplicateop_settings.cpp (2 lines)
M		plugins/paintops/deform/kis_deform_paintop_settings.cpp (2 lines)
M		plugins/paintops/dynadraw/kis_dyna_paintop_settings.cpp (3 lines)
M		plugins/paintops/experiment/kis_experiment_paintop_settings.cpp (1 line)
M		plugins/paintops/gridbrush/kis_grid_paintop_settings.cpp (1 line)
M		plugins/paintops/libpaintop/kis_brush_based_paintop_settings.cpp (2 lines)
M		plugins/paintops/spray/kis_spray_paintop_settings.cpp (1 line)