Diffusion kdesrc-build cabaa3435d5a

first-run: Make it possible to run system installer on first run.
Concern Raisedcabaa3435d5a
Actions

Authored by mpyne on Oct 22 2018, 1:21 AM.

Description

first-run: Make it possible to run system installer on first run.

Tested with OpenSuSE docker image (opensuse-leap:latest). With it, this
sequence of commands run in the container succeeds, with kdesrc-build
git dir bind-mounted to /opt/kdesrc-build in the container:

export PATH=/opt/kdesrc-build:$PATH
kdesrc-build --initial-setup
kdesrc-build --metadata-only
kdesrc-build extra-cmake-modules

I mention containers, but that's mostly to make it easier to test. There
is separate work by others to actually make kdesrc-build part of a fully
container-based workflow which I don't want/need to reinvent.

Details

Auditors
romangg
Committed
mpyneOct 22 2018, 1:21 AM
Parents
R365:a6bbfba12a8c: first-run: Make --initial-setup work in minimal env, impl sample-rc.
Branches
Unknown
Tags
Unknown
romangg raised a concern with this commit.Oct 24 2018, 12:14 PM
romangg added a subscriber: romangg.

No success in launching kdesrc-build with this commit (on Neon dev unstable). It shows the error message:

Couldn't load the base platform for kdesrc-build!
More detail might be available in error-31859.log

Checking out before this commit makes kdesrc-build work again.

This commit now has outstanding concerns.Oct 24 2018, 12:14 PM
romangg added a comment.Oct 24 2018, 2:12 PM

I have discovered now the error log (in the home directory):

Mon Oct 22 18:36:48 2018
Can't locate ksb/Debug.pm in @INC (you may need to install the ksb::Debug module) (@INC contains: /home/roman/bin/../share/kdesrc-build/modules /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.1 /usr/local/share/perl/5.26.1 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at /home/roman/bin/kdesrc-build line 108.
mpyne added a comment.Oct 25 2018, 11:50 PM

Sorry about that! Should be fixed in 7295eaca3093c127ddafe832a17f6dc6b5eedc2e

romangg added a comment.Oct 29 2018, 9:04 AM

Thanks, this does not seem to fix the problem though. Still get the same error message.

romangg added a comment.Nov 2 2018, 2:47 PM

The problem seems to only occur if one tries to run the script from the source directory. After make install running from /usr/bin/ works. Not sure if this is intended, normally one would expect a script to run from the source directory. But if it is intended https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source#Install_kdesrc-build must be changed.

mpyne added a comment.Nov 7 2018, 3:25 AM
In R365:cabaa3435d5a627d658ad05dd96503a002d39f7a#3708827, @romangg wrote:

The problem seems to only occur if one tries to run the script from the source directory. After make install running from /usr/bin/ works. Not sure if this is intended, normally one would expect a script to run from the source directory. But if it is intended https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source#Install_kdesrc-build must be changed.

You're right that running from a symlink to kdesrc-build still crashed. That was fixed a couple of days ago (thanks to dhaumann), and a testcase added for all 3 separate ways of referencing the script when executing it.

Changes (1)

PathPackages
Mmodules/ksb/FirstRun.pm

R365:cabaa3435d5a

View Options

modules/ksb/FirstRun.pm

Loading...