Ignore control characters in the text part of Xpe "ESC]" sequences

Authored by ahmadsamir on May 23 2018, 11:51 PM.

Description

Ignore control characters in the text part of Xpe "ESC]" sequences

Summary:
Ignore control characters in the text part of Xpe (OSC, Operating System
Control) of the form "ESC]Pn;Pt\a" escape sequences; this matches what
XTerm docs say.

If userTitle is an empty string, set the window title to a blank space
when showWindowTitleOnTitleBar is enabled; basically if the user sets
the title to an empty string, leave it as-is.

BUG: 315581
FIXED-IN: 18.08

Test Plan:

  • unset PROMPT_COMMAND, in case the shell is configured to set the window title via that variable
  • Make sure "Show window title on the title bar" is enabled
  • Execute:

$ /usr/bin/echo -e 'j\e]2;\n\aj'

  • The window title is changed to the tab title text; and the output looks like this:

j
j

  • Apply the diff, build, and try again, the window title should be set to an empty string (really a blank space), and the output should look like:

jj

Reviewers: Konsole, hindenburg

Reviewed By: Konsole, hindenburg

Subscribers: konsole-devel, Konsole

Tags: Konsole

Differential Revision: https://phabricator.kde.org/D13078

Details

Committed
hindenburgMay 24 2018, 12:34 PM
Reviewer
Konsole
Differential Revision
D13078: Ignore control characters in the text part of Xpe "ESC]" sequences
Parents
R319:847b72358d6c: Silence -Wformat-truncation warnings
Branches
Unknown
Tags
Unknown