Ignore control characters in the text part of Xpe "ESC]" sequences
ClosedPublic

Authored by ahmadsamir on May 23 2018, 8:09 PM.

Details

Summary

Ignore control characters in the text part of Xpe (OSC, Operating System
Control) of the form "ESC]Pn;Pt\a" escape sequences; this matches what
XTerm docs say.

If userTitle is an empty string, set the window title to a blank space
when showWindowTitleOnTitleBar is enabled; basically if the user sets
the title to an empty string, leave it as-is.

BUG: 315581
FIXED-IN: 18.08

Test Plan
  • unset PROMPT_COMMAND, in case the shell is configured to set the window title via that variable
  • Make sure "Show window title on the title bar" is enabled
  • Execute:

$ /usr/bin/echo -e 'j\e]2;\n\aj'

  • The window title is changed to the tab title text; and the output looks like this:

j
j

  • Apply the diff, build, and try again, the window title should be set to an empty string (really a blank space), and the output should look like:

jj

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.May 23 2018, 8:09 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMay 23 2018, 8:09 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
ahmadsamir requested review of this revision.May 23 2018, 8:09 PM
hindenburg accepted this revision.May 24 2018, 12:33 PM
hindenburg edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.May 24 2018, 12:34 PM
This revision was automatically updated to reflect the committed changes.