Replace setUserTitle() with setSessionAttribute()
ClosedPublic

Authored by ahmadsamir on May 27 2018, 12:59 PM.

Details

Summary

Session:setUserTitle() changes various attributes of the current
session/tab, not just the title; change the name from "Title" to
"sessionAttribute" as that's more representative of what the function
does. Propagate the change where appropriate throughout the code.

Remove Vt102Emulation::requestWindowAttribute(), as it's not used
anywhere.

Update a couple of links to Qt and XTerm documentation, respectively.

Test Plan

Every thing should work as before, for example changing the window title:

  • "Show window title on the titlebar" must be enabled
  • unset PROMPT_COMMAND (in case it already sets the window title)
  • Change the window title:

printf "\033]2;%s\007" "testing"

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.May 27 2018, 12:59 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMay 27 2018, 12:59 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
ahmadsamir requested review of this revision.May 27 2018, 12:59 PM
ahmadsamir updated this revision to Diff 34969.
ahmadsamir edited the summary of this revision. (Show Details)

Corrections in the commit message

hindenburg accepted this revision.May 28 2018, 6:07 PM
hindenburg added a subscriber: hindenburg.

Thanks looks fine

This revision is now accepted and ready to land.May 28 2018, 6:07 PM
This revision was automatically updated to reflect the committed changes.