Do not disconnect all StorageAccess signals when unmounting

Authored by thsurrel on Nov 13 2018, 10:05 AM.

Description

Do not disconnect all StorageAccess signals when unmounting

Summary:
The problem is caused by the fact device interfaces returned by
Solid (e.g. item->device().as<Solid::StorageAccess>()) are not
full objects, but only references/pointers to a per-device-object,
i.e. requesting the same interface for a device will return the same
address every time.

If the interface is used used in multiple places, calling disconnect
on the interface address disconnects the signals for all users.

BUG: 400992

Test Plan:
In Dolphin, mount a local partition (e.g. a Windows partition)
then unmount it (right click on it in Places, then Unmount).
Try to access it again by clicking on it in Places, we should
get access to it correctly.

Reviewers: Dolphin, Frameworks, bruns, elvisangelaccio

Reviewed By: Dolphin, elvisangelaccio

Subscribers: elvisangelaccio, kfm-devel

Tags: Dolphin

Differential Revision: https://phabricator.kde.org/D16857

Details

Committed
thsurrelNov 17 2018, 1:43 PM
Reviewer
Dolphin
Differential Revision
D16857: Do not disconnect all StorageAccess signals when unmounting
Parents
R318:c900f7d255aa: Improve Ux for the places panel's hidden items
Branches
Unknown
Tags
Unknown