Use the right scope for the installpath variable

Authored by apol on Jun 5 2017, 3:24 PM.

Description

Use the right scope for the installpath variable

Summary:
Only mark package as installed if it was successfully extracted

Don't store all installed files in the knsregistry file

At the moment we were storing every file, for big packages (for example
icon themes like Papyrus) this meant ~5 MiB of paths that had to be loaded
when the engine was created.
This patch makes it so instead of adding all the contents of the directory
it will only list the extracted directories so they can recursively be
removed. I don't think it's a supported workflow to be adding stuff in an
extracted directory anyway.

Test Plan:
Tests pass, tried un/installing massive icon themes. Also massif
reports a much lower memory consumption.

Reviewers: Frameworks, whiting, leinir

Reviewed By: leinir

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D6104

Details

Committed
apolJun 6 2017, 1:07 PM
Reviewer
leinir
Differential Revision
D6104: Use the right scope for the installpath variable
Parents
R304:bb03e880e1a4: add .arcconfig file
Branches
Unknown
Tags
Unknown