Replace "Fit Width" feature with "Fill"
ba63c8a44f46
Actions

Authored by slenz on Feb 28 2018, 9:16 AM.

Description

Replace "Fit Width" feature with "Fill"

Summary:
Fit width is arguably less useful than a more general Fill feature. This replaces "Fit Width" with "Fill", fitting width or height, depending on what fills the window.

FEATURE: 195579

Test Plan: Use Fill with landscape and portrait pictures with the window in landscape and portrait size.

Reviewers: Gwenview, ngraham, rkflx

Reviewed By: Gwenview, ngraham, rkflx

Subscribers: rkflx, muhlenpfordt, ngraham, Gwenview

Tags: Gwenview

Differential Revision: https://phabricator.kde.org/D10844

Details

Committed

rkflx

Feb 28 2018, 9:16 AM

Reviewer

Gwenview

Differential Revision

D10844: Replace "Fit Width" feature with "Fill"

Parents

R260:0fdf03d3cd43: Merge remote-tracking branch 'origin/Applications/17.12'

Branches

Unknown

Tags

Unknown

rkflx committed R260:ba63c8a44f46: Replace "Fit Width" feature with "Fill" (authored by slenz).Feb 28 2018, 9:16 AM

@slenz Just wanted to pass this along:

Eike Hein 2018-02-28 09:32:22 UTC
Pretty amazing - 9 years after I filed this :) Thanks!

rkflx mentioned this in R260:a8dcc6cade3c: Deduplicate some conditional branches in RasterImageView.Aug 7 2018, 10:14 PM

Changes (17)

				Path	Packages
	M			doc/index.docbook
	M			lib/documentview/abstractdocumentviewadapter.h
	M			lib/documentview/abstractimageview.cpp
	M			lib/documentview/abstractimageview.h
	M			lib/documentview/documentview.cpp
	M			lib/documentview/documentview.h
	M			lib/documentview/documentviewcontroller.cpp
	M			lib/documentview/documentviewcontroller.h
	M			lib/documentview/documentviewsynchronizer.cpp
	M			lib/documentview/documentviewsynchronizer.h
	M			lib/documentview/rasterimageview.cpp
	M			lib/documentview/rasterimageviewadapter.cpp
	M			lib/documentview/rasterimageviewadapter.h
	M			lib/documentview/svgviewadapter.cpp
	M			lib/documentview/svgviewadapter.h
	M			lib/zoomwidget.cpp
	M			lib/zoomwidget.h