Use standard QToolButtons so that their icons use the right colors

Authored by ngraham on Sep 27 2017, 4:31 PM.

Description

Use standard QToolButtons so that their icons use the right colors

Summary:
BUG: 383059

For the inline context buttons, use the standard QToolButton widget which respects theming so that icons are always visible

Test Plan:
Tested in KDE Neon with Breeze light and dark, Oxygen, and all default color schemes. Big improvement.

Current with Breeze:

Patched version with Breeze:

Patched version with Breeze Dark:

Reviewers: KDE Applications, vtasoulas, broulik, rkflx

Reviewed By: rkflx

Subscribers: mart, rkflx

Differential Revision: https://phabricator.kde.org/D7988

Details

Committed
ngrahamSep 27 2017, 6:38 PM
Reviewer
rkflx
Differential Revision
D7988: Use standard QToolButtons so that their icons use the right colors
Parents
R260:b74114a1da7b: GIT_SILENT made messages (after extraction)
Branches
Unknown
Tags
Unknown
rkflx added a subscriber: rkflx.Sep 27 2017, 6:53 PM

Strangely, your commit also touches org.kde.gwenview.appdata.xml, essentially reverting b74114a1da7b. This was not in the Diff on Phab.

I guess this should be fixed somehow, but you'd have to ask someone else how to do that (possibly by cherry-picking?)

Weird. I've cherry-picked that commit back in.