Diffusion Syntax Highlighting 91d29a45389e

precompute attribute format for context & rules
91d29a45389e
Actions

Authored by cullmann on Sep 1 2018, 3:35 PM.

Description

precompute attribute format for context & rules

Summary:
avoid costly lookup, e.g. 3% of runtime of highlighting

simplifies the highlightLine stuff, as we only need to keep track of format changes,
not lookup contexts in addition

fixes that we don't see that formats change if name is equal in different
definitions

accessors are inline, the classes are internal anyways

Test Plan:
make && make test

updated references, now we properly applyFormat if we walk from one into a other
definition with same name formats

Reviewers: vkrause, dhaumann

Reviewed By: vkrause

Subscribers: kwrite-devel, kde-frameworks-devel

Tags: Kate, Frameworks

Differential Revision: https://phabricator.kde.org/D15207

Details

Committed

cullmann

Sep 1 2018, 4:08 PM

Reviewer

vkrause

Differential Revision

D15207: precompute attribute format for context & rules

Parents

R216:2475bc4dd2ca: avoid word delimiter check at start of keyword

Branches

Unknown

Tags

Unknown

cullmann committed R216:91d29a45389e: precompute attribute format for context & rules (authored by cullmann).Sep 1 2018, 4:08 PM

Changes (54)

				Path	Packages
	M			autotests/html/csharp.cs.html
	M			autotests/html/highlight.cmake.html
	M			autotests/html/highlight.cpp.html
	M			autotests/html/highlight.css.html
	M			autotests/html/highlight.dox.html
	M			autotests/html/highlight.hs.html
	M			autotests/html/highlight.js.html
	M			autotests/html/highlight.lhs.html
	M			autotests/html/highlight.lua.html
	M			autotests/html/highlight.qml.html
	M			autotests/html/highlight.tex.html
	M			autotests/html/highlight.y.html
	M			autotests/html/modelines.py.html
	M			autotests/html/test.Rd.html
	M			autotests/html/test.coffee.html
	M			autotests/html/test.htm.html
	M			autotests/html/test.js.html
	M			autotests/html/test.py.html
	M			autotests/html/test.qml.html
	M			autotests/html/test.te.html
	M			autotests/reference/csharp.cs.ref
	M			autotests/reference/highlight.cmake.ref
	M			autotests/reference/highlight.cpp.ref
	M			autotests/reference/highlight.css.ref
	M			autotests/reference/highlight.dox.ref
	M			autotests/reference/highlight.gdb.ref
	M			autotests/reference/highlight.hs.ref
	M			autotests/reference/highlight.js.ref
	M			autotests/reference/highlight.lhs.ref
	M			autotests/reference/highlight.lua.ref
	M			autotests/reference/highlight.qml.ref
	M			autotests/reference/highlight.tex.ref
	M			autotests/reference/highlight.y.ref
	M			autotests/reference/modelines.py.ref
	M			autotests/reference/review128925-1.css.ref
	M			autotests/reference/review128925-2.css.ref
	M			autotests/reference/test.Rd.ref
	M			autotests/reference/test.coffee.ref
	M			autotests/reference/test.htm.ref
	M			autotests/reference/test.js.ref
	M			autotests/reference/test.jsx.ref
	M			autotests/reference/test.py.ref
	M			autotests/reference/test.qml.ref
	M			autotests/reference/test.te.ref
	M			src/lib/CMakeLists.txt
	M			src/lib/abstracthighlighter.cpp
	M			src/lib/context.cpp
	M			src/lib/context_p.h
	M			src/lib/definition.cpp
	D			src/lib/matchresult.cpp
	M			src/lib/matchresult_p.h
	M			src/lib/repository.cpp
	M			src/lib/rule.cpp
	M			src/lib/rule_p.h