forbid sub-rules

Authored by cullmann on Sep 2 2018, 4:16 PM.

Description

forbid sub-rules

Summary:
sub-rules are a hassle

they are only allowed for ints and floats

they can easily replaced with an extra context

I will patch all .xml files and forbid that, will make the implementation
much nicer, as that is the only place we allow any "endless" nesting
in the implementation

Test Plan:
make && make test

> this is only the first part, need to finish all remaining .xml files

Reviewers: vkrause, dhaumann

Subscribers: kwrite-devel, kde-frameworks-devel

Tags: Kate, Frameworks

Differential Revision: https://phabricator.kde.org/D15219

Details

Committed
cullmannSep 2 2018, 5:14 PM
Differential Revision
D15219: forbid sub-rules
Parents
R216:1a642b017dc5: don't run the benchmark tests on the CI
Branches
Unknown
Tags
Unknown
dhaumann added inline comments.
/src/lib/rule.cpp
165

You could issue a qCWarning in case other people still use subrules in local hl files

cullmann added inline comments.Sep 3 2018, 7:20 AM
/src/lib/rule.cpp
165

If you know how to do nicely without messing up the parsing, add it ;=)
I didn't dare to try to dive down in the element :0