Fix warnings
3a7f50d5f55b
Actions

Authored by apol on Mar 30 2020, 3:24 PM.

Description

Fix warnings

Summary:
Remove unused variables and members.
We were often storing the q of classes without ever needing them. I'd
just do it when it's useful. We do it in the private class so it can
always be added, removes boilerplate code.

Don't use std::move when returning temporary QImage. The compiler is
smart enough to know to do it but produces the warning "moving a
temporary object prevents copy elision".

Remove unused lambda captured variables.

Test Plan: Getting much cleaner build logs

Reviewers: Frameworks, KWin, zzag

Reviewed By: KWin, zzag

Subscribers: zzag, kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D28442

Details

Committed

apol	Mar 30 2020, 5:13 PM

Reviewer

KWin

Differential Revision

D28442: Fix warnings

Parents

R127:665dc779c668: Remove cppcheck from kwayland

Branches

Unknown

Tags

Unknown

apol committed R127:3a7f50d5f55b: Fix warnings (authored by apol).Mar 30 2020, 5:13 PM

Changes (18)

				Path	Packages
	M			autotests/client/test_shm_pool.cpp
	M			autotests/client/test_wayland_outputmanagement.cpp
	M			autotests/client/test_wayland_shell.cpp
	M			src/client/appmenu.cpp
	M			src/client/event_queue.cpp
	M			src/client/idleinhibit.cpp
	M			src/client/server_decoration_palette.cpp
	M			src/server/buffer_interface.cpp
	M			src/server/display.cpp
	M			src/server/eglstream_controller_interface.cpp
	M			src/server/fakeinput_interface.cpp
	M			src/server/output_interface.cpp
	M			src/server/plasmavirtualdesktop_interface.cpp
	M			src/server/plasmawindowmanagement_interface.cpp
	M			src/server/textinput_interface_v0.cpp
	M			tests/shadowtest.cpp
	M			tests/touchclienttest.cpp
	M			tests/xdgforeigntest.cpp

Fix warnings3a7f50d5f55bActions

Description

Details

Changes (18)

R127:3a7f50d5f55b

autotests/client/test_shm_pool.cpp

autotests/client/test_wayland_outputmanagement.cpp

autotests/client/test_wayland_shell.cpp

src/client/appmenu.cpp

src/client/event_queue.cpp

src/client/idleinhibit.cpp

src/client/server_decoration_palette.cpp

src/server/buffer_interface.cpp

src/server/display.cpp

src/server/eglstream_controller_interface.cpp

src/server/fakeinput_interface.cpp

src/server/output_interface.cpp

src/server/plasmavirtualdesktop_interface.cpp

src/server/plasmawindowmanagement_interface.cpp

src/server/textinput_interface_v0.cpp

tests/shadowtest.cpp

tests/touchclienttest.cpp

tests/xdgforeigntest.cpp

Fix warnings
3a7f50d5f55b
Actions