Fix warnings
ClosedPublic

Authored by apol on Mar 30 2020, 3:24 PM.

Details

Reviewers
zzag
Group Reviewers
Frameworks
KWin
Commits
R127:3a7f50d5f55b: Fix warnings
Summary

Remove unused variables and members.
We were often storing the q of classes without ever needing them. I'd
just do it when it's useful. We do it in the private class so it can
always be added, removes boilerplate code.

Don't use std::move when returning temporary QImage. The compiler is
smart enough to know to do it but produces the warning "moving a
temporary object prevents copy elision".

Remove unused lambda captured variables.

Test Plan

Getting much cleaner build logs

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Mar 30 2020, 3:24 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 30 2020, 3:24 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Mar 30 2020, 3:24 PM
zzag accepted this revision.Mar 30 2020, 4:04 PM
zzag added a subscriber: zzag.
zzag added inline comments.
src/server/buffer_interface.cpp
285–291

Please re-indent this code.

tests/xdgforeigntest.cpp
133

You don't need to put a semicolon after the Q_UNUSED macro.

This revision is now accepted and ready to land.Mar 30 2020, 4:04 PM
This revision was automatically updated to reflect the committed changes.
apol marked an inline comment as done.