Diffusion KWin 51a727fc6b06

Send requested size in all configure events

Authored by davidedmundson on Oct 10 2018, 11:03 AM.

Description

Send requested size in all configure events

Summary:
Previously when updating the state we would send a configure event with
the size 0,0. This means the client chooses the size. For regular window
this works as most toolkits treat this to mean the size that we
previously requested. It's not explicit in the spec either way.

For maximised windows it's a problem, the spec clearly states that when
maximised clients must follow the size given. Telling the client to be
0,0 doesn't make sense.

By always sending our last requested size we remove any ambiguity.

Test Plan:
Ran
Maximised some windows and changed focus
WAYLAND_DEBUG showed we weren't sending a configure with 0,0
after startup

Reviewers: KWin, zzag

Reviewed By: KWin, zzag

Subscribers: zzag, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D16055

Details

Auditors
romangg
Committed
davidedmundsonOct 10 2018, 11:32 AM
Reviewer
KWin
Differential Revision
D16055: Send requested size in all configure events
Parents
R108:b1b1360ec3fb: [effects/fadedesktop] Set animation as a fullscreen effect
Branches
Unknown
Tags
Unknown
romangg raised a concern with this commit.EditedOct 11 2018, 3:54 PM
romangg added a subscriber: romangg.
  • Plasmashell background is black
  • Plasmashell surfaces are misplaced.
  • Native windows are opened in minimal size only.
This commit now has outstanding concerns.Oct 11 2018, 3:54 PM
zzag added a subscriber: zzag.EditedOct 11 2018, 5:02 PM
  • Plasmashell background is black
  • Plasmashell surfaces are misplaced.
  • Native windows are opened in minimal size only.

Can confirm only the last one.

EDIT: Nvm, can confirm the first two also.

At least the commit is only on master.

Commit works fine for me, I suspect a Qt 5.11 vs 5.12 difference is at play.

What are both of you using?

zzag added a comment.Oct 11 2018, 5:17 PM

Qt 5.11.2

davidedmundson requested verification of this commit.Oct 11 2018, 10:51 PM

Resolved.

This commit now requires verification by auditors.Oct 11 2018, 10:51 PM
romangg accepted this commit.Oct 12 2018, 7:36 AM

Fix tested and issues are gone.

All concerns with this commit have now been addressed.Oct 12 2018, 7:36 AM