fix keyboard focus problem in GridBrowserDelegate with an automatic qml test
ClosedPublic
Actions

Authored by mgallien on Jan 18 2018, 9:23 PM.

Details

Reviewers

astippich

Group Reviewers

Elisa

Commits

Summary

fix keyboard focus handling in GridBrowserDelegate including an automatic test for it

Test Plan

the automatic test fails without the modifications of the delegate andd pass with them

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.Jan 18 2018, 9:23 PM

mgallien created this revision.

Does not build, I think you forgot to add one file

autotests/CMakeLists.txt
447	This file is missing

should be enough for now

This revision is now accepted and ready to land.Jan 23 2018, 8:17 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		CMakeLists.txt (2 lines)
M		autotests/CMakeLists.txt (16 lines)
A	M	autotests/elisaqmltests.cpp (22 lines)
A	M	autotests/qmltests/tst_GridBrowserDelegate.qml (337 lines)
M		src/qml/GridBrowserDelegate.qml (19 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25610	cf95542		Jan 18 2018, 9:23 PM	★	★
Diff 2	25789	eba7aea	- fix name of test qml file	Jan 23 2018, 7:30 AM	★	★
Diff 3	25845	4c0727c	R255:09a702fcc36c1435901106696afec8404dba6ee3	Jan 23 2018, 8:23 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
a8df52b02e5d	234dbfb79a59	616eb130de72	Matthieu Gallien	add three tests for mouse and keyboard usage of GridBrowserDelegate	Jan 23 2018, 7:26 AM
616eb130de72	3e243b31f452	7acb914429cb	Matthieu Gallien	fix name of test qml file	Jan 19 2018, 6:01 AM
7acb914429cb	8bdf2e605bb5	eba7aea44ee9	Matthieu Gallien	fix keyboard focus problem in GridBrowserDelegate with an automatic qml test (Show More…)	Jan 18 2018, 9:21 PM