| lepagevalleeemmanuel |
| Kirigami |
This is the first step in actually creating a valid Qt static plugin.
Currently, when used as a static library, it is expected to be a
subdirectory of the project instead of a "proper" Qt plugin. This
patch and the ones that follow aim to make Kirigami a plugin just
as Qt official ones.
builds and works in both modes, however KirigamiPlugin::registerTypes()
still seems to be needed, which we want to get rid of in the end
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I wonder if it would make sense to always ship the qml files as qrc in the plugin. Have you considered it?
| src/CMakeLists.txt | ||
|---|---|---|
| 47 | I'd reuse the target_link_libraries calls. Better duplicate minimum. You can have an extra target_link_libraries(kirigamiplugin PRIVATE KF5::Kirigami2) if needed. | |
| src/controls/qmldir | ||
| 2 ↗ | (On Diff #25405) | Why is it commented? |
(this code is originally from me, then improved by notmart and is part of the greater work to ship static appimages)
I did consider it and went ahead in ring-kde and put every QML in QRC even in non static builds. I think it makes sense, but makes debugging a bit harder and I didn't want to change too much things to fix the static plugin. Shipping assets in QRC doesn't seem to be common outside of some KDE projects that take cross platform more seriously.
I did consider it and went ahead in ring-kde and put every QML in QRC even in non static builds. I think it makes sense, but makes debugging a bit harder and I didn't want to change too much things to fix the static plugin. Shipping assets in QRC doesn't seem to be common outside of some KDE projects that take cross platform more seriously.
I put all qml files in a qrc file for Discover, hasn't been an issue.
may make sense...
i would save it for another poatch tough this is big enough already :)
I tried the patch on my CI and it compiled and linked. I also reviewed the changes between my patchset and this diff and approve the change, I also agree with Apol about the target_link_libraries issue. It should be mutualized between the if and else. So "almost ship it!"
now the library definition is not duplicated
and both the cmake and qmake example do usa the static plugin
| src/CMakeLists.txt | ||
|---|---|---|
| 69 | When trying to install it using kdesrc-build, it complains about not finding the specified directory. I assume its supposed to be available? | |