Differential D9880

Fix build with >=attr-2.4.48
ClosedPublic
Actions

Authored by asturmlechner on Jan 14 2018, 9:36 PM.

Details

Reviewers
mgallien
Group Reviewers
Frameworks
Commits
R286:4bbc7a2f5c77: Fix build with >=attr-2.4.48
Summary

It was looking for long deprecated attr/xattr.h header.

Test Plan

Built fine with attr-2.4.47 and 2.4.48.

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asturmlechner created this revision.Jan 14 2018, 9:36 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 14 2018, 9:36 PM
asturmlechner requested review of this revision.Jan 14 2018, 9:36 PM
mgallien added a comment.Jan 15 2018, 9:39 PM

Are you sure attr/xattr.h is deprecated ?
I did look at what debian provides with version 2.4.47 and there seems to have a valid attr/xattr.h file.
I also did found some partial information by searching the web but nothing conclusive.

asturmlechner added a comment.Jan 16 2018, 12:19 AM
In D9880#191545, @mgallien wrote:

Are you sure attr/xattr.h is deprecated ?

Yep, it is gone in 2.4.48, but the commit that removed it is from 2015: http://git.savannah.nongnu.org/cgit/attr.git/commit/?id=7921157890d07858d092f4003ca4c6bae9fd2c38

mgallien accepted this revision.Jan 16 2018, 5:33 PM

Sorry for not having checked the correct git repository.

This revision is now accepted and ready to land.Jan 16 2018, 5:33 PM
Closed by commit R286:4bbc7a2f5c77: Fix build with >=attr-2.4.48 (authored by Lars Wendler <polynomial-c@gentoo.org>, committed by asturmlechner). · Explain WhyJan 16 2018, 5:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcmake/FindXattr.cmake (2 lines)
Msrc/xattr_p.h (4 lines)

Diff 25492

View Options

cmake/FindXattr.cmake

Loading...
View Options

src/xattr_p.h

Loading...