Do not call into NETWinInfo in AbstractClient::setSkipPager
ClosedPublic
Actions

Authored by graesslin on Jan 13 2018, 6:58 PM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

Summary

There's a call to a virtual doSetSkipPager for performing this call and
Client implements it with the code which now is removed.

This fixes a crash when using setSkipPager for a Wayland window.

Test Plan

Crash which happens with a new test case (see dependent phab
request) is fixed.

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a project: KWin. · View Herald TranscriptJan 13 2018, 6:58 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin requested review of this revision.Jan 13 2018, 6:58 PM

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 13 2018, 6:58 PM

Makes sense.

This revision is now accepted and ready to land.Jan 14 2018, 7:39 AM

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 14 2018, 7:39 AM

This revision was automatically updated to reflect the committed changes.

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 14 2018, 10:20 AM

			Path	Packages
M			abstract_client.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25279	b8f4361		Jan 13 2018, 6:58 PM	★	★
Diff 2	25301	f7f0a64	R108:85ef2831dbc1b62543ee25f1691b5cfb3d2e6bb1	Jan 14 2018, 10:19 AM	★	★

Status	Author	Revision
Closed	graesslin	D9870 Add support for apply initial keep above/below window rules
Closed	graesslin	D9866 Add support for initial apply rules for skip (taskbar\|pager\|switcher)
Closed	graesslin	D9865 Do not call into NETWinInfo in AbstractClient::setSkipPager