Differential D9865

Do not call into NETWinInfo in AbstractClient::setSkipPager
ClosedPublic
Actions

Authored by graesslin on Jan 13 2018, 6:58 PM.

Details

Reviewers
hein
Group Reviewers
KWin
Plasma
Commits
R108:85ef2831dbc1: Do not call into NETWinInfo in AbstractClient::setSkipPager
Summary

There's a call to a virtual doSetSkipPager for performing this call and
Client implements it with the code which now is removed.

This fixes a crash when using setSkipPager for a Wayland window.

Test Plan

Crash which happens with a new test case (see dependent phab
request) is fixed.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Jan 13 2018, 6:58 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 13 2018, 6:58 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
graesslin requested review of this revision.Jan 13 2018, 6:58 PM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 13 2018, 6:58 PM
hein accepted this revision.Jan 14 2018, 7:39 AM
hein added a subscriber: hein.

Makes sense.

This revision is now accepted and ready to land.Jan 14 2018, 7:39 AM
Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 14 2018, 7:39 AM
Closed by commit R108:85ef2831dbc1: Do not call into NETWinInfo in AbstractClient::setSkipPager (authored by graesslin). · Explain WhyJan 14 2018, 10:20 AM
This revision was automatically updated to reflect the committed changes.
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 14 2018, 10:20 AM

Revision Contents
Changeset List

PathPackages
Mabstract_client.cpp (1 line)

Diff 25301

View Options

abstract_client.cpp

Loading...